First of all, hi everyone, I'm a microelectronics junior engineer... and a GNU/Linux The Gimp user.

The Gimp JPEG plug in does not allow to save defaults settings from session to session. It does exists for the PNG one (see bug #63610).

I decided yesterday to write the same thing for jpeg, I submit the source code (mainly inspired from the PNG implementation). Be cool, this is my first GTK writing, first plug in for The Gimp, first active participation to a OpenSource project ;-).

I also noticed a crash happening when checking the "use restart markers" and then enabling the "preview" toggle. I found the bug, it is now fully working. Maybe this issue has been corrected in dev version, but I downloaded the last stable one.

I sent a first mail with the code source attached, but it has been blocked by size.Source code is at : http://p.guepe.free.fr/gimp_jpeg/

EL

Le samedi 30 juin 2007 à 09:17 -0700, Akkana Peck a écrit :

guepe writes:

The Gimp JPEG plug in does not allow to save defaults settings from session to session. It does exists for the PNG one (see bug #63610).

I decided yesterday to write the same thing for jpeg, I submit the source code (mainly inspired from the PNG implementation).

That should be a popular patch! It's something that lots of people have asked for.

I sent a first mail with the code source attached, but it has been blocked by size.Source code is at : http://p.guepe.free.fr/gimp_jpeg/

The best way to submit patches is usually to attach them to a bugzilla bug. Submitting them in a mailing list makes it really easy for them to get forgotten before anyone has time to review them.

In bugzilla, the main bug on this seems to be http://bugzilla.gnome.org/show_bug.cgi?id=63610 though there's a very similar bug that depends on it, http://bugzilla.gnome.org/show_bug.cgi?id=120829 Probably one of those would be the best place to attach your patch.

Ok, I posted the source code of the plug in containing modifications to the bug #63610 : http://bugzilla.gnome.org/show_bug.cgi?id=63610

It is possible that EXIF cause problems to that patch. I'm not sure, but possibly EXIFs are never found by this plug in. Could someone know a method to test it ?

EL

Le samedi 30 juin 2007 à 19:21 +0200, gg@catking.net a écrit :

On Sat, 30 Jun 2007 17:33:28 +0200, guepe wrote:

I also noticed a crash happening when checking the "use restart markers" and then enabling the "preview" toggle. I found the bug, it is now fully working. Maybe this issue has been corrected in dev version, but I downloaded the last stable one.
I sent a first mail with the code source attached, but it has been blocked by size.Source code is at : http://p.guepe.free.fr/gimp_jpeg/ EL
--

Thanks, nice improvement considering you're new to the code.

The best way to submit a patch is via bugzilla, that way you dont get blocked for size and it's the correct place to make submittions. Use the mailing list for discussions.

Open a new report about the bug and post your patch as an attachment.

You should really make you patch against the current SVN archive. So that it can be readily applied and added to the project. Also avoids fixing something someone else may be working on.

There's instructions on gimp.org http://developer.gimp.org/svn.html

HTH.

Ok, I cheked the actual version of jpeg.c on the svn server.... I need to reimplement my code into it, because things have changed since 2.2.13 version. So, consider that my patch will probably come tomorrow.

EL

Le samedi 30 juin 2007 à 19:21 +0200, gg@catking.net a écrit :

On Sat, 30 Jun 2007 17:33:28 +0200, guepe wrote:

I also noticed a crash happening when checking the "use restart markers" and then enabling the "preview" toggle. I found the bug, it is now fully working. Maybe this issue has been corrected in dev version, but I downloaded the last stable one.
I sent a first mail with the code source attached, but it has been blocked by size.Source code is at : http://p.guepe.free.fr/gimp_jpeg/ EL
--

Thanks, nice improvement considering you're new to the code.

The best way to submit a patch is via bugzilla, that way you dont get blocked for size and it's the correct place to make submittions. Use the mailing list for discussions.

Open a new report about the bug and post your patch as an attachment.

You should really make you patch against the current SVN archive. So that it can be readily applied and added to the project. Also avoids fixing something someone else may be working on.

There's instructions on gimp.org http://developer.gimp.org/svn.html

HTH.

Ok guys... I finally managed to reimplement my elder code to the svn one. You can test my patches from the bug page : http://bugzilla.gnome.org/show_bug.cgi?id=63610

Any comment/feedback ?

EL