RSS/Atom feed Twitter
Site is read-only, email is disabled
  1. Chat
  2. Useful links
  3. Polls

Featured content

Two new build bugs

This discussion is connected to the gimp-developer-list.gnome.org mailing list which is provided by the GIMP developers and not related to gimpusers.com.

This is a read-only list on gimpusers.com so this discussion thread is read-only, too.

6 of 6 messages available
Toggle history

Please log in to manage your subscriptions.
Two new build bugs Daniel Richard G. 07 Jun 04:29
  Two new build bugs Daniel Richard G. 08 Jun 07:53
   Two new build bugs Sven Neumann 08 Jun 20:51
    Two new build bugs Sven Neumann 08 Jun 21:10
     Two new build bugs Daniel Richard G. 08 Jun 22:10
      Two new build bugs Sven Neumann 08 Jun 22:18
Daniel Richard G.
2007-06-07 04:29:40 UTC (over 18 years ago)

Two new build bugs

I'd like to draw attention to two bugs I encountered in building GIMP, both having to do with my slightly-less-than-conventional approach to same:

srcdir vs. builddir fixes for out-of-source-tree builds http://bugzilla.gnome.org/show_bug.cgi?id=444960

Empty SCHEME_EXPORT causes duplicate symbol definition http://bugzilla.gnome.org/show_bug.cgi?id=444964

(Sven, I got your note on the oilify.c patch. I'm going to see if I can finally catch up on that; this is me bootstrapping a new working tree.)

--Daniel

Daniel Richard G.
2007-06-08 07:53:47 UTC (over 18 years ago)

Two new build bugs

With these bug fixes going in, not only is it now possible to build GIMP from a clean/read-only SVN tree (i.e. only touched with ./autogen.sh), "make distcheck" is working too. Well, almost, but it's very nearly there.

Fixes for "make dist" from a clean/ro SVN tree http://bugzilla.gnome.org/show_bug.cgi?id=445374

This will all help to keep generated files out of a version-controlled working source tree. (The fewer question marks you get from "svn stat", the better.)

--Daniel

On Wed, 2007 Jun 06 22:29:40 -0400, Daniel Richard G. wrote:

I'd like to draw attention to two bugs I encountered in building GIMP, both having to do with my slightly-less-than-conventional approach to same:

srcdir vs. builddir fixes for out-of-source-tree builds http://bugzilla.gnome.org/show_bug.cgi?id=444960

Empty SCHEME_EXPORT causes duplicate symbol definition http://bugzilla.gnome.org/show_bug.cgi?id=444964

Sven Neumann
2007-06-08 20:51:54 UTC (over 18 years ago)

Two new build bugs

Hi,

On Fri, 2007-06-08 at 01:53 -0400, Daniel Richard G. wrote:

With these bug fixes going in, not only is it now possible to build GIMP from a clean/read-only SVN tree (i.e. only touched with ./autogen.sh), "make distcheck" is working too. Well, almost, but it's very nearly there.

Fixes for "make dist" from a clean/ro SVN tree http://bugzilla.gnome.org/show_bug.cgi?id=445374

This will all help to keep generated files out of a version-controlled working source tree. (The fewer question marks you get from "svn stat", the better.)

You shouldn't get any question marks at all, even when building in the source tree. That's what svn:ignore is good for.

Sven

Sven Neumann
2007-06-08 21:10:22 UTC (over 18 years ago)

Two new build bugs

Hi,

On Fri, 2007-06-08 at 20:51 +0200, Sven Neumann wrote:

This will all help to keep generated files out of a version-controlled working source tree. (The fewer question marks you get from "svn stat", the better.)

Actually, now that we accepted some of the proposed changes, building outside the source directory is somewhat broken. We have generated files that are intentionally kept under version control. If you build with srcdir != builddir and do changes to the source files, then 'svn status' will not any longer notify you about the changes to the generated files that need to be committed together with the changed source files.

Looks like I have perhaps been a little too hasty accepting your changes. We might want to revert some of them.

Sven

Daniel Richard G.
2007-06-08 22:10:37 UTC (over 18 years ago)

Two new build bugs

On Fri, 2007 Jun 08 21:10:22 +0200, Sven Neumann wrote:

Actually, now that we accepted some of the proposed changes, building outside the source directory is somewhat broken. We have generated files that are intentionally kept under version control. If you build with srcdir != builddir and do changes to the source files, then 'svn status' will not any longer notify you about the changes to the generated files that need to be committed together with the changed source files.

Looks like I have perhaps been a little too hasty accepting your changes. We might want to revert some of them.

Notwithstanding the pitfalls of checking in generated files, that's a situation where you explicitly want an in-source-tree build. The whole point of srcdir != builddir is to keep srcdir pristine.

What is the intention behind version-controlling those files? I didn't notice anything particularly painful to generate.

--Daniel

Sven Neumann
2007-06-08 22:18:08 UTC (over 18 years ago)

Two new build bugs

Hi,

On Fri, 2007-06-08 at 16:10 -0400, Daniel Richard G. wrote:

What is the intention behind version-controlling those files? I didn't notice anything particularly painful to generate.

Most of these files are in SVN because they contain translatable strings. The message catalogs are built from the files in SVN, the translators shouldn't have to build the tree for that.

Other files are in SVN because it is easier to examine differences on the generated files. Keeping them in SVN allows us to easily create diffs. Also when changing the source files, having the generated file in SVN allows us to easily examine the difference in the generated code.

Sven