Sign up now! · Forgot password?
RSS/Atom feed Twitter

libmypaint needs patching for recent GEGL

This discussion is connected to the gimp-developer-list.gnome.org mailing list which is provided by the GIMP developers and not related to gimpusers.com.

This is a read-only list on gimpusers.com so this discussion thread is read-only, too.

2 of 2 messages available
Toggle history

Please log in to manage your subscriptions.

libmypaint needs patching for recent GEGL Helmut Jarausch via gimp-developer-list 12 Mar 12:26
  libmypaint needs patching for recent GEGL Øyvind Kolås 12 Mar 15:12
Helmut Jarausch via gimp-developer-list
2019-03-12 12:26:37 UTC (3 months ago)

libmypaint needs patching for recent GEGL

Hi,

I'm using GEGL GIT 2019/06/03. libmypaint (1.3.0) does not compile with this version of GEGL.

Can anybody please confirm that the following patch is OK ?

--- a/gegl/mypaint-gegl-surface.c.ORIG 2016-06-02 17:43:32.000000000 +0200
+++ b/gegl/mypaint-gegl-surface.c 2019-03-12 13:16:31.626735235 +0100
@@ -78,7 +78,7 @@

if (buffer_is_native(self)) { GeglBufferIterator *iterator = gegl_buffer_iterator_new(self->buffer, &tile_bbox, 0, self->format, - read_write_flags, GEGL_ABYSS_NONE);
+ read_write_flags, GEGL_ABYSS_NONE,100);

// Read out gboolean completed = gegl_buffer_iterator_next(iterator); @@ -88,7 +88,7 @@
g_critical("Unable to get tile aligned access to GeglBuffer");
request->buffer = NULL; } else {
- request->buffer = (uint16_t *)(iterator->data[0]); + request->buffer = (uint16_t *)(iterator->items[0].data); }

// So we can finish the iterator in tile_request_end()

Many thanks, Helmut

Øyvind Kolås
2019-03-12 15:12:46 UTC (3 months ago)

libmypaint needs patching for recent GEGL

On Tue, Mar 12, 2019 at 1:26 PM Helmut Jarausch via gimp-developer-list wrote:

This looks mostly OK, though without even looking at the code I suspect 100 is MUCH higher than necessary, this number allocates room in the iterator datastructure for the maximum number of buffers that are iterated in parallel. The old default was 8, the sum of gegl_buffer_iterator_add calls + 1 is the minimum value that should be set.

/pippin

I'm using GEGL GIT 2019/06/03.
libmypaint (1.3.0) does not compile with this version of GEGL.

Can anybody please confirm that the following patch is OK ?

--- a/gegl/mypaint-gegl-surface.c.ORIG 2016-06-02 17:43:32.000000000 +0200
+++ b/gegl/mypaint-gegl-surface.c 2019-03-12 13:16:31.626735235 +0100
@@ -78,7 +78,7 @@

if (buffer_is_native(self)) { GeglBufferIterator *iterator = gegl_buffer_iterator_new(self->buffer, &tile_bbox, 0, self->format, - read_write_flags, GEGL_ABYSS_NONE);
+ read_write_flags, GEGL_ABYSS_NONE,100);

// Read out gboolean completed = gegl_buffer_iterator_next(iterator); @@ -88,7 +88,7 @@
g_critical("Unable to get tile aligned access to GeglBuffer");
request->buffer = NULL; } else {
- request->buffer = (uint16_t *)(iterator->data[0]); + request->buffer = (uint16_t *)(iterator->items[0].data); }

// So we can finish the iterator in tile_request_end()

Many thanks, Helmut
_______________________________________________ gimp-developer-list mailing list
List address: gimp-developer-list@gnome.org List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list List archives: https://mail.gnome.org/archives/gimp-developer-list