RSS/Atom feed Twitter
Site is read-only, email is disabled
  1. Chat
  2. Useful links
  3. Polls

Featured content

Where is the code which is called when mask is selected?

This discussion is connected to the gimp-developer-list.gnome.org mailing list which is provided by the GIMP developers and not related to gimpusers.com.

This is a read-only list on gimpusers.com so this discussion thread is read-only, too.

4 of 4 messages available
Toggle history

Please log in to manage your subscriptions.
Where is the code which is called when mask is selected? Christopher Howard 19 Aug 21:33
  Where is the code which is called when mask is selected? LightningIsMyName 19 Aug 21:42
   Where is the code which is called when mask is selected? Christopher Howard 19 Aug 22:32
  Where is the code which is called when mask is selected? Michael Natterer 21 Aug 10:35
Christopher Howard
2009-08-19 21:33:56 UTC (over 15 years ago)

Where is the code which is called when mask is selected?

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

Hi. I wanted to fix trivial bug #563770. I won't bore you with all the details, but I suspect the problem lies somewhere in the code that is called when the user selects the layer mask rectangle inside the layers dialog. In other words, after the user adds a mask to a layer, a small layer mask preview box (icon?) appears to the right of the visibility icon and the small layer preview box, and I think the bug is being caused by something that occurs when the user presses this layer mask preview box.

However, I am having trouble finding that code. I have been tracing function calls in gimplayertreeview.c, layers-actions.c, layer-add-mask-dialog.c, gimplayer.c, and elsewhere trying to find the right signal-slot connection or the relevant function but I somehow keep missing it or failing to recognize it.

Could someone point me in the right direction?

- -- Christopher Howard
http://indicium.us
http://theologia.indicium.us
I digitally sign /all/ my e-mails via PGP. If you receive any e-mail supposedly from me without my valid PGP digital signature, please take additional steps to verify the authenticity of the message. -----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkqMU6QACgkQQ5FLNdi0BcWQmwCffWYBV2HPdzDXcGyv0XvlrQSg QRYAoJfAm/PHz31X2H2cAjATOJW+jbxB
=yMMy
-----END PGP SIGNATURE-----

LightningIsMyName
2009-08-19 21:42:48 UTC (over 15 years ago)

Where is the code which is called when mask is selected?

Hello,

I do believe that the code is here: http://git.gnome.org/cgit/gimp/tree/app/widgets/gimplayertreeview.c#n1375 It's the gimp_layer_tree_view_mask_clicked function inside app/widgets/gimplayertreeview.c
You can see it's signal connected here http://git.gnome.org/cgit/gimp/tree/app/widgets/gimplayertreeview.c#n398

On Wed, Aug 19, 2009 at 10:33 PM, Christopher Howard wrote:

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

Hi. I wanted to fix trivial bug #563770. I won't bore you with all the details, but I suspect the problem lies somewhere in the code that is called when the user selects the layer mask rectangle inside the layers dialog. In other words, after the user adds a mask to a layer, a small layer mask preview box (icon?) appears to the right of the visibility icon and the small layer preview box, and I think the bug is being caused by something that occurs when the user presses this layer mask preview box.

However, I am having trouble finding that code. I have been tracing function calls in gimplayertreeview.c, layers-actions.c, layer-add-mask-dialog.c, gimplayer.c, and elsewhere trying to find the right signal-slot connection or the relevant function but I somehow keep missing it or failing to recognize it.

Could someone point me in the right direction?

- -- Christopher Howard
http://indicium.us
http://theologia.indicium.us
I digitally sign /all/ my e-mails via PGP. If you receive any e-mail supposedly from me without my valid PGP digital signature, please take additional steps to verify the authenticity of the message. -----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkqMU6QACgkQQ5FLNdi0BcWQmwCffWYBV2HPdzDXcGyv0XvlrQSg QRYAoJfAm/PHz31X2H2cAjATOJW+jbxB
=yMMy
-----END PGP SIGNATURE-----

Christopher Howard
2009-08-19 22:32:12 UTC (over 15 years ago)

Where is the code which is called when mask is selected?

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

LightningIsMyName wrote:

Hello,

I do believe that the code is here: http://git.gnome.org/cgit/gimp/tree/app/widgets/gimplayertreeview.c#n1375 It's the gimp_layer_tree_view_mask_clicked function inside app/widgets/gimplayertreeview.c
You can see it's signal connected here http://git.gnome.org/cgit/gimp/tree/app/widgets/gimplayertreeview.c#n398

On Wed, Aug 19, 2009 at 10:33 PM, Christopher Howard wrote: Hi. I wanted to fix trivial bug #563770. I won't bore you with all the details, but I suspect the problem lies somewhere in the code that is called when the user selects the layer mask rectangle inside the layers dialog. In other words, after the user adds a mask to a layer, a small layer mask preview box (icon?) appears to the right of the visibility icon and the small layer preview box, and I think the bug is being caused by something that occurs when the user presses this layer mask preview box.

However, I am having trouble finding that code. I have been tracing function calls in gimplayertreeview.c, layers-actions.c, layer-add-mask-dialog.c, gimplayer.c, and elsewhere trying to find the right signal-slot connection or the relevant function but I somehow keep missing it or failing to recognize it.

Could someone point me in the right direction?

Thanks a bunch. Next time I'll try to look more closely at the function prototypes before asking.

- -- Christopher Howard
http://indicium.us
http://theologia.indicium.us
I digitally sign /all/ my e-mails via PGP. If you receive any e-mail supposedly from me without my valid PGP digital signature, please take additional steps to verify the authenticity of the message. -----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkqMYUwACgkQQ5FLNdi0BcWsqACdFUTXTxT22LENm/M7OJWgpFtD bVsAn35Qice3bZIO86aEVPgPc4JVf8Hs
=6K3g
-----END PGP SIGNATURE-----

Michael Natterer
2009-08-21 10:35:27 UTC (over 15 years ago)

Where is the code which is called when mask is selected?

On Wed, 2009-08-19 at 11:33 -0800, Christopher Howard wrote:

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

Hi. I wanted to fix trivial bug #563770. I won't bore you with all the details, but I suspect the problem lies somewhere in the code that is called when the user selects the layer mask rectangle inside the layers dialog. In other words, after the user adds a mask to a layer, a small layer mask preview box (icon?) appears to the right of the visibility icon and the small layer preview box, and I think the bug is being caused by something that occurs when the user presses this layer mask preview box.

However, I am having trouble finding that code. I have been tracing function calls in gimplayertreeview.c, layers-actions.c, layer-add-mask-dialog.c, gimplayer.c, and elsewhere trying to find the right signal-slot connection or the relevant function but I somehow keep missing it or failing to recognize it.

Could someone point me in the right direction?

In app/core/gimplayermask.c (gimp_layer_mask_real_edit_changed) it calls gimp_image_selection_control() with GIMP_SELECTION_LAYER_ON which ends up in app/display/gimpdisplayshell-selection.c (gimp_display_shell_selection_control) where it calls selection_layer_draw() without checking whether drawing of the layer boundary is enabled or not.

The fix is to simply not call selection_layer_draw() if the layer boundary is disabled.

ciao, --mitch