RSS/Atom feed Twitter
Site is read-only, email is disabled
  1. Chat
  2. Useful links
  3. Polls

Featured content

[PATCH] Suggestion on how to deal with obsolete data resources

This discussion is connected to the gimp-developer-list.gnome.org mailing list which is provided by the GIMP developers and not related to gimpusers.com.

This is a read-only list on gimpusers.com so this discussion thread is read-only, too.

4 of 4 messages available
Toggle history

Please log in to manage your subscriptions.
[PATCH] Suggestion on how to deal with obsolete data resources Martin Nordholts 11 Aug 20:42
  [PATCH] Suggestion on how to deal with obsolete data resources SHIRAKAWA Akira 12 Aug 17:36
  [PATCH] Suggestion on how to deal with obsolete data resources Sven Neumann 12 Aug 20:50
   [PATCH] Suggestion on how to deal with obsolete data resources Martin Nordholts 12 Aug 22:38
Martin Nordholts
2009-08-11 20:42:54 UTC (over 15 years ago)

[PATCH] Suggestion on how to deal with obsolete data resources

Hi,

It has already been concluded that we want to get rid of a few data resources for GIMP 2.8 and also that this requires a mechanism to support backwards compatibility for scripts that uses the soon-to-be-removed resources.

The attached patch makes resources which have "gimp-obsolete-files" as part of the path considered obsolete and will not be part of any of the traditional resource management. We make the assumption/have the requirement that obsolete resources are not added, removed or changed during a running GIMP session.

To test the patch, do

$ cd $prefix/share/gimp/2.0/brushes/ $ mkdir gimp-obsolete-files
$ mv Circle-* gimp-obsolete-files $ mv gimp-obsolete-files/Circle-*19* .

then run GIMP and look at the brushes in the UI. Only the largest Circle* brushes are available. But you can still execute File -> Create -> Logos -> Frosty.. which uses "Circle Fuzzy (11)".

Any comments on the proposed way to deal with obsolete resources?

/ Martin

SHIRAKAWA Akira
2009-08-12 17:36:17 UTC (over 15 years ago)

[PATCH] Suggestion on how to deal with obsolete data resources

Martin Nordholts wrote:
[cut]

then run GIMP and look at the brushes in the UI. Only the largest Circle* brushes are available. But you can still execute File -> Create -> Logos -> Frosty.. which uses "Circle Fuzzy (11)".

Any comments on the proposed way to deal with obsolete resources?

Unfortunately since I'm using Windows there's not easy way for me to try this patch, but in my opinion from what you describe this seems a fair way to handle this problem.

I assume this is only a temporary workaround that will be eventually eliminated in future major versions of GIMP, right? Because at some point probably most of the current resources or those which will come out in next version will become obsolete, I think (when/if there will be major changes to the whole brush system, for example).

Sven Neumann
2009-08-12 20:50:14 UTC (over 15 years ago)

[PATCH] Suggestion on how to deal with obsolete data resources

Hi,

On Tue, 2009-08-11 at 20:45 +0200, Martin Nordholts wrote:

It has already been concluded that we want to get rid of a few data resources for GIMP 2.8 and also that this requires a mechanism to support backwards compatibility for scripts that uses the soon-to-be-removed resources.

It's certainly a possible solution. But it means that the obsolete data resources are still loaded, taking up memory and slowing down start-up. I wonder if we could instead create brushes such as "Circle Fuzzy (11)" on the fly. Shouldn't be too hard to make up some code that maps obsolete brush names to parameters for generated brushes. Then we could really remove most of the obsolete brushes.

Sven

Martin Nordholts
2009-08-12 22:38:17 UTC (over 15 years ago)

[PATCH] Suggestion on how to deal with obsolete data resources

On 08/12/2009 08:50 PM, Sven Neumann wrote:

Hi,

On Tue, 2009-08-11 at 20:45 +0200, Martin Nordholts wrote:

It has already been concluded that we want to get rid of a few data resources for GIMP 2.8 and also that this requires a mechanism to support backwards compatibility for scripts that uses the soon-to-be-removed resources.

It's certainly a possible solution. But it means that the obsolete data resources are still loaded, taking up memory and slowing down start-up. I wonder if we could instead create brushes such as "Circle Fuzzy (11)" on the fly. Shouldn't be too hard to make up some code that maps obsolete brush names to parameters for generated brushes. Then we could really remove most of the obsolete brushes.

That's a nice idea, but it is slightly more messy for non-parametric resources. Since we are going to obsolete non-parametric resources too I'll commit my patch soonish. Lazy loading of resources would be nice of course, but it is more important to get 2.8 out.

/ Martin