RSS/Atom feed Twitter
Site is read-only, email is disabled
  1. Chat
  2. Useful links
  3. Polls

Featured content

babl portability patches, and a test failure

This discussion is connected to the gimp-developer-list.gnome.org mailing list which is provided by the GIMP developers and not related to gimpusers.com.

This is a read-only list on gimpusers.com so this discussion thread is read-only, too.

2 of 11 messages available
Toggle history

Please log in to manage your subscriptions.
20090326055632.GK11979@thor... 07 Oct 20:27
  babl portability patches, and a test failure Kevin Cozens 26 Mar 22:03
   babl portability patches, and a test failure Sven Neumann 27 Mar 20:06
20090217141230.GN23868@thor... 07 Oct 20:27
1235428034.21193.4.camel@be... 07 Oct 20:27
20090224032212.GZ23868@thor... 07 Oct 20:27
1235514442.4408.2.camel@bender 07 Oct 20:27
1236542219.18222.46.camel@b... 07 Oct 20:27
20090310024629.GB62147@thor... 07 Oct 20:27
20090324214126.GJ11979@thor... 07 Oct 20:27
49C9CA9C.2040507@gmail.com 07 Oct 20:27
Kevin Cozens
2009-03-26 22:03:31 UTC (over 16 years ago)

babl portability patches, and a test failure

Gary V. Vaughan wrote:

Has anyone been able to find time to look at my patch queue for babl?

One minor thing I noticed is the patch which adds and include of config.h so it is done in all(?) files. Is it really necessary to include the header even if it isn't currently needed by some of the files?

Sven Neumann
2009-03-27 20:06:52 UTC (over 16 years ago)

babl portability patches, and a test failure

Hi,

On Thu, 2009-03-26 at 17:03 -0400, Kevin Cozens wrote:

Gary V. Vaughan wrote:

Has anyone been able to find time to look at my patch queue for babl?

One minor thing I noticed is the patch which adds and include of config.h so it is done in all(?) files. Is it really necessary to include the header even if it isn't currently needed by some of the files?

Yes, definitely. The config.h header file has defines that affect how code is compiled. Including it in one place and not in another may result in bugs that are very hard to track down. It is common practice to include the config.h header always and always first.

Sven