RSS/Atom feed Twitter
Site is read-only, email is disabled

[PATCH] Gradient-Fu for 1.3.x - Complete but not Final

This discussion is connected to the gimp-developer-list.gnome.org mailing list which is provided by the GIMP developers and not related to gimpusers.com.

This is a read-only list on gimpusers.com so this discussion thread is read-only, too.

3 of 3 messages available
Toggle history

Please log in to manage your subscriptions.

[PATCH] Gradient-Fu for 1.3.x - Complete but not Final Shlomi Fish 22 Dec 21:51
  [PATCH] Gradient-Fu for 1.3.x - Complete but not Final Dave Neary 23 Dec 09:51
   [PATCH] Gradient-Fu for 1.3.x - Complete but not Final Shlomi Fish 23 Dec 11:00
Shlomi Fish
2003-12-22 21:51:29 UTC (over 20 years ago)

[PATCH] Gradient-Fu for 1.3.x - Complete but not Final

Check:

http://t2.technion.ac.il/~shlomif/grad-fu/1-3-x.html

for a link to the up-to-date patch. This patch incorporates all the changes that were present in its previous incarnations and then a nice featurette of moving a segment.

Furthremore, it adds some refactoring to the gradient editor, in which several functions were placed under app/core/.

Of course, it is possible that there are bugs and/or style issues. Especially note that I changed one function like this:

<<< {
- seg->left = new_l + (seg->left - orig_l) * scale; + if (seg->prev)
+ seg->left = new_l + (seg->left - orig_l) * scale; seg->middle = new_l + (seg->middle - orig_l) * scale; - seg->right = new_l + (seg->right - orig_l) * scale; + if (seg->next)
+ seg->right = new_l + (seg->right - orig_l) * scale;

This is to make it more akin to its equivalent in the editor's code. (duplicate code probably)

Regards,

Shlomi Fish

---------------------------------------------------------------------- Shlomi Fish shlomif@vipe.technion.ac.il Home Page: http://t2.technion.ac.il/~shlomif/

An apple a day will keep a doctor away. Two apples a day will keep two doctors away.

Falk Fish

Dave Neary
2003-12-23 09:51:58 UTC (over 20 years ago)

[PATCH] Gradient-Fu for 1.3.x - Complete but not Final

Hi Shlomi,

Shlomi Fish wrote:

Check:

http://t2.technion.ac.il/~shlomif/grad-fu/1-3-x.html

for a link to the up-to-date patch.

Thanks for the patch. Would you mind attaching this to the bug report, just in case your hard-drive fries over the holidays or something?

Cheers, Dave.

Shlomi Fish
2003-12-23 11:00:31 UTC (over 20 years ago)

[PATCH] Gradient-Fu for 1.3.x - Complete but not Final

On Tue, 23 Dec 2003, Dave Neary wrote:

Hi Shlomi,

Shlomi Fish wrote:

Check:

http://t2.technion.ac.il/~shlomif/grad-fu/1-3-x.html

for a link to the up-to-date patch.

Thanks for the patch. Would you mind attaching this to the bug report, just in case your hard-drive fries over the holidays or something?

Sure thing. Even though, I have a copy of it on two different computers. t2.technion.ac.il is the Technion's Undergrad Students' computer and it runs a very reliable Solaris system. (which did not cause me any problems so far). The security there leaves a lot to be desired, though.

Regards,

Shlomi Fish

Cheers,
Dave.

---------------------------------------------------------------------- Shlomi Fish shlomif@vipe.technion.ac.il Home Page: http://t2.technion.ac.il/~shlomif/

An apple a day will keep a doctor away. Two apples a day will keep two doctors away.

Falk Fish