Hi Elle,

On Mon, 27 Jun 2016 06:23:01 -0400 Elle Stone wrote:

Two icons in "icons/Symbolic/64/" - gimp-frame.png and gimp-texture.png - are grayscale images, one with and one without an alpha channel.

It looks like all the other symbolic icons in the various folders are RGB images with an alpha channel.

While running "make" in my patched GIMP there was a segmentation fault at building icons/Symbolic/64/gimp-texture.png. This never happened before, and maybe it would never happen in default GIMP.

Anyway, modifying these two icons to be RGB with an alpha channel allowed the build process to finish.

On my Mageia Linux v6 x86-64 system with up-to-date GIMP git repo ( commit 5ca2794d400d9fe09afabc9bdee77520a61bc82a ) with babl, gegl and libmypaint installed from up-to-date git - all unpatched, then "make" completes fine.

That put aside, "make check" fails.

Regards,

Shlomi

-----------------------------------------------------------------
Shlomi Fish       http://www.shlomifish.org/
The Case for File Swapping - http://shlom.in/file-swap

I often wonder why I hang out with so many people who are so pedantic. And
then I remember — because they are so pedantic.
    — an Israeli Perl Monger

Please reply to list if it's a mailing list post - http://shlom.in/reply .

Hi,

On Mon, Jun 27, 2016 at 2:59 PM, Elle Stone wrote:

On 06/27/2016 08:08 AM, Shlomi Fish wrote:

On my Mageia Linux v6 x86-64 system with up-to-date GIMP git repo ( commit 5ca2794d400d9fe09afabc9bdee77520a61bc82a ) with babl, gegl and libmypaint installed from up-to-date git - all unpatched, then "make" completes fine.

That put aside, "make check" fails.

I also haven't had a problem with default GIMP not compiling because of the pngs in the icons folder, so I was very hesitant to report that my patched GIMP seg-faulted upon reaching the grayscale pngs.

However: (1)The png on which "make" failed is not like the other symbolic theme pngs, being a grayscale png.
(2)Changing the grayscale pngs to match all the other RGB with alpha channel pngs allowed "make" to finish.

Which suggests that perhaps the two grayscale pngs were really supposed to be RGB with alpha channel pngs, to match all the other pngs in the icons folder.

I know a lot of work has been done to make the new symbolic themes, so I though it was best to go ahead and mention the two grayscale pngs.

Yes, you do good by reporting any issue.

I cann see these 2 images are indeed in grayscale whereas others are RGB. This said, symbolic icons are all actual grayscale images, so actually the fact that most files are RGB is likely more an error than these 2 being grayscale.

Also you say `make` segfaults. What is the exact error? Could you paste the build logs somewhere?
The only thing we build regarding these symbolic images are the inverted versions, which we make through a call to gegl. Therefore, I would imagine that what segfaults is the gegl call on these images (assumption which could be confirmed, or not, with your build log).

Does this command segfault: $ gegl ./icons/Symbolic/64/gimp-texture.png -o bla.png -- gegl:invert-gamma (on success it will create a bla.png, inverted from gimp-texture.png. You can delete bla.png after)

If it indeed segfaults, you may have a problem with your GEGL binary (or some op) more annoying that a bug in GIMP build. If that's not it, then I'll just wait for your logs. :-)

Jehan

Best,
Elle

_______________________________________________ gimp-developer-list mailing list
List address: gimp-developer-list@gnome.org List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list List archives: https://mail.gnome.org/archives/gimp-developer-list

ZeMarmot open animation film
http://film.zemarmot.net
Patreon: https://patreon.com/zemarmot
Tipeee: https://www.tipeee.com/zemarmot

Hi,

On Thu, Jun 30, 2016 at 3:35 PM, Elle Stone wrote:

On 06/29/2016 07:35 PM, Jehan Pagès wrote:

Does this command segfault:
$ gegl ./icons/Symbolic/64/gimp-texture.png -o bla.png -- gegl:invert-gamma
(on success it will create a bla.png, inverted from gimp-texture.png. You can delete bla.png after)

Yes, in my patched babl/GEGL/GIMP that command segfaults on gimp-texture.png (which doesn't have an alpha channel), but not on gimp-frame.png (which does have an alpha channel). Thanks! for sharing that command - it allowed me to figure out which commit I made to my patched GEGL that introduced the segfault.

No prob. This is actually simply the command our makefiles run to invert the symbolic icons (to create the inverted symbolic).

As far as default babl/GEGL/GIMP, probably the only relevant information is that two of the pngs that are used to generate GIMP's new themes are not like the other pngs, which apparently is not a problem.

Yeah, let's say it's maybe not clean enough and I may want to even these all out in the end. But for now I let the icon designer work more freely with the icon theme. No need to bother him too much with technical stuff all the time. :-)

Also apart from the discrepancy of format, I don't think that's actually much a problem (nobody will see any usage difference).

So my apologies for
the noise on the mailing list!

No problem.

Best,
Elle

Jehan

ZeMarmot open animation film
http://film.zemarmot.net
Patreon: https://patreon.com/zemarmot
Tipeee: https://www.tipeee.com/zemarmot