RSS/Atom feed Twitter
Site is read-only, email is disabled

[PATCH] MAXPATHLEN bug on GNU

This discussion is connected to the gimp-developer-list.gnome.org mailing list which is provided by the GIMP developers and not related to gimpusers.com.

This is a read-only list on gimpusers.com so this discussion thread is read-only, too.

6 of 6 messages available
Toggle history

Please log in to manage your subscriptions.

[PATCH] MAXPATHLEN bug on GNU Robert Millan 03 Apr 13:48
  [PATCH] MAXPATHLEN bug on GNU Sven Neumann 03 Apr 14:09
   [PATCH] MAXPATHLEN bug on GNU Robert Millan 03 Apr 20:25
    [PATCH] MAXPATHLEN bug on GNU Raphaël Quinet 04 Apr 13:52
   [PATCH] MAXPATHLEN bug on GNU Patrick McFarland 04 Apr 04:14
    [PATCH] MAXPATHLEN bug on GNU Sven Neumann 04 Apr 08:41
Robert Millan
2003-04-03 13:48:08 UTC (about 21 years ago)

[PATCH] MAXPATHLEN bug on GNU

hello!

MAXPATHLEN is used unconditionaly in gimp's sources. POSIX allows not to define it, so systems that don't have a path length limit, like GNU, break on building the gimp.

please apply this little patch to fix it:

--- gimp1.2-1.2.3/app/app_procs.c.old 2003-03-29 19:39:54.000000000 +0100 +++ gimp1.2-1.2.3/app/app_procs.c 2003-03-29 19:40:26.000000000 +0100 @@ -132,7 +132,11 @@
static gint logo_area_width = 0;
static gint logo_area_height = 0;
static gint show_logo = SHOW_NEVER; +#ifdef MAXPATHLEN
static gint max_label_length = MAXPATHLEN; +#else
+static gint max_label_length = 0;
+#endif
void

Sven Neumann
2003-04-03 14:09:34 UTC (about 21 years ago)

[PATCH] MAXPATHLEN bug on GNU

Hi,

Robert Millan writes:

MAXPATHLEN is used unconditionaly in gimp's sources. POSIX allows not to define it, so systems that don't have a path length limit, like GNU, break on building the gimp.

generally, you should use Bugzilla (http://bugzilla.gnome.org/) to report such problems. In this particular case, I'll take care of fixing it right now, so there's no need to open a bug report for it.

please apply this little patch to fix it:

--- gimp1.2-1.2.3/app/app_procs.c.old 2003-03-29 19:39:54.000000000 +0100 +++ gimp1.2-1.2.3/app/app_procs.c 2003-03-29 19:40:26.000000000 +0100 @@ -132,7 +132,11 @@
static gint logo_area_width = 0;
static gint logo_area_height = 0;
static gint show_logo = SHOW_NEVER; +#ifdef MAXPATHLEN
static gint max_label_length = MAXPATHLEN; +#else
+static gint max_label_length = 0;
+#endif

well, actually this is just an initialization and MAXPATHLEN is a rather bad choice anyway. I'll just change it to some sane fixed value instead.

Salut, Sven

Robert Millan
2003-04-03 20:25:37 UTC (about 21 years ago)

[PATCH] MAXPATHLEN bug on GNU

On Thu, Apr 03, 2003 at 02:09:34PM +0200, Sven Neumann wrote:

Hi,

generally, you should use Bugzilla (http://bugzilla.gnome.org/) to report such problems. In this particular case, I'll take care of fixing it right now, so there's no need to open a bug report for it.

Sorry. I looked for a bug tracking system in the gimp site but couldn't find any sign of it. will note for next time.

well, actually this is just an initialization and MAXPATHLEN is a rather bad choice anyway. I'll just change it to some sane fixed value instead.

ok, thanks!

Patrick McFarland
2003-04-04 04:14:37 UTC (about 21 years ago)

[PATCH] MAXPATHLEN bug on GNU

On 03-Apr-2003, Sven Neumann wrote:

well, actually this is just an initialization and MAXPATHLEN is a rather bad choice anyway. I'll just change it to some sane fixed value instead.

So _what is_ a good sane fixed value?

Sven Neumann
2003-04-04 08:41:33 UTC (about 21 years ago)

[PATCH] MAXPATHLEN bug on GNU

Hi,

Patrick McFarland writes:

On 03-Apr-2003, Sven Neumann wrote:

well, actually this is just an initialization and MAXPATHLEN is a rather bad choice anyway. I'll just change it to some sane fixed value instead.

So _what is_ a good sane fixed value?

any value is as good as any other since if the code works correctly the inital value is never used. I've choosen 64 which should be a reasonable choice if for some reason the initialization would not be performed (which would be a bug).

Salut, Sven

Raphaël Quinet
2003-04-04 13:52:58 UTC (about 21 years ago)

[PATCH] MAXPATHLEN bug on GNU

On Thu, 3 Apr 2003 20:25:37 +0200, Robert Millan wrote:

On Thu, Apr 03, 2003 at 02:09:34PM +0200, Sven Neumann wrote:

Hi,

generally, you should use Bugzilla (http://bugzilla.gnome.org/) to report such problems. In this particular case, I'll take care of fixing it right now, so there's no need to open a bug report for it.

Sorry. I looked for a bug tracking system in the gimp site but couldn't find any sign of it. will note for next time.

http://www.gimp.org/

On the homepage, you find this nice paragraph:

Bugs, bugs, bugs! The current development version of Gimp is loaded with tons of bugs, as Bugzilla will show you in the _list_of_open_bugs_ (including the _list_of_enhancement_proposals_). If you think you've found a new one, you can _submit_a_bug_report_.

If the links on the home page (present since March 2000) are not sufficient, you can also go to http://www.gimp.org/devel_ver.html (the page about the development version of the GIMP) and you will see a nice table of links that can be used to query the bug database in various ways.

So it shouldn't have been that hard to find a sign of a bug database... ;-)

-Raphaël