RSS/Atom feed Twitter
Site is read-only, email is disabled
  1. Chat
  2. Useful links
  3. Polls

Featured content

[PATCH] app: avoid D-Bus error message when built without D-Bus support

This discussion is connected to the gimp-developer-list.gnome.org mailing list which is provided by the GIMP developers and not related to gimpusers.com.

This is a read-only list on gimpusers.com so this discussion thread is read-only, too.

3 of 3 messages available
Toggle history

Please log in to manage your subscriptions.
[PATCH] app: avoid D-Bus error message when built without D-Bus support Ingo Brückl 06 Oct 01:07
  [PATCH] app: avoid D-Bus error message when built without D-Bus support Ingo Brückl 20 Oct 09:13
   [PATCH] app: avoid D-Bus error message when built without D-Bus support Michael Schumacher 20 Oct 09:51
Ingo Brückl
2016-10-06 01:07:25 UTC (over 7 years ago)

[PATCH] app: avoid D-Bus error message when built without D-Bus support

It is pointless to connect to a message bus when GIMP has been compiled without D-Bus support. Although it's harmless, the resulting error message is confusing and should be avoided.

So only compile gimp_unique_dbus_open() in its entirety if HAVE_DBUS_GLIB.
---
app/unique.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/app/unique.c b/app/unique.c index 8e0f477..649f3ab 100644
--- a/app/unique.c
+++ b/app/unique.c
@@ -71,7 +71,7 @@ gimp_unique_dbus_open (const gchar **filenames, gboolean as_new) {
#ifndef GIMP_CONSOLE_COMPILATION
-
+#if HAVE_DBUS_GLIB
GDBusConnection *connection;
GError *error = NULL;

@@ -158,6 +158,7 @@ gimp_unique_dbus_open (const gchar **filenames, g_clear_error (&error);
}
#endif
+#endif

return FALSE;
}
--
2.9.2

Ingo Brückl
2016-10-20 09:13:22 UTC (over 7 years ago)

[PATCH] app: avoid D-Bus error message when built without D-Bus support

It is pointless to connect to a message bus when GIMP has been compiled without D-Bus support. Although it's harmless, the resulting error message is confusing and should be avoided.

So only compile gimp_unique_dbus_open() in its entirety if HAVE_DBUS_GLIB.

app/unique.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Anyone?

Michael Schumacher
2016-10-20 09:51:42 UTC (over 7 years ago)

[PATCH] app: avoid D-Bus error message when built without D-Bus support

On October 20, 2016 11:13:22 AM GMT+02:00, "Ingo Brückl" wrote:

It is pointless to connect to a message bus when GIMP has been

compiled

without D-Bus support. Although it's harmless, the resulting error message is confusing and should be avoided.

So only compile gimp_unique_dbus_open() in its entirety if HAVE_DBUS_GLIB.

app/unique.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Anyone?

Can you file a bug in Bugzilla and attach the patch there?