After having used this feature for a few weeks now in production work, I find it saves a lot of clicks/time, and I'm happy to have it applied to trunk as-is.
I think other professional workflows will benefit greatly from it in various ways.

-C

On Thu, May 26, 2016 at 3:08 PM, Ben wrote:

============

Date: Wed, 25 May 2016 18:36:36 +0100 From: C R

It's definitely faster, and more convenient. I also like the fact that ctrl+shift+clicking a masked layer removes the mask. It makes a pain-free toggle, I can see myself using it a lot.

The only thing I would add is that if there is a selection on the canvas, that the mask be made from that selection. More often than not I'm making a mask out of the current selection, so it would save me several hotkey presses after using the new ctrl+shift+click layer mask feature.

Thanks for trying it out. You can also use ctrl-alt-click to bring up the dialog instead of the predefined value.

============

Date: Wed, 25 May 2016 22:30:11 +0300

From: Alexandre Prokoudine
Something I'm not sure about is that Ctrl+Shift+Click on the mask preview toggles visibility of the mask. I never used this shortcut on the mask before, so I'm not certain if it had existed before or if it has just been added as part of the patch. In other words: is it expected behavior?

There was no such shortcut till the patch. Using it either adds or removes a layer mask (if it exists on the layer).

Another thing is that another mask-related setting -- default quick

mask color -- is on a different tab. Should they be on the same tab instead?

I don't think so.

Other than that, I'd be happy to see the patch applied.

Thanks for trying it out. You can also use ctrl-alt-click to bring up the dialog instead of the predefined value.

Ben

_______________________________________________ gimp-developer-list mailing list
List address: gimp-developer-list@gnome.org List membership:
https://mail.gnome.org/mailman/listinfo/gimp-developer-list List archives: https://mail.gnome.org/archives/gimp-developer-list

Can I bribe someone to commit/add this to trunk (even on a trial basis)? :) It's become a staple in my workflow. I have no doubt others will benefit greatly. I would very much miss it if it's not included in future releases.

Thanks for your attention, and help in this matter, and let me know what bounty is desired for the work! (Best coffee in London, anyone?)

-C

On Thu, Jun 2, 2016 at 7:17 AM, C R wrote:

After having used this feature for a few weeks now in production work, I find it saves a lot of clicks/time, and I'm happy to have it applied to trunk as-is.
I think other professional workflows will benefit greatly from it in various ways.

-C

On Thu, May 26, 2016 at 3:08 PM, Ben wrote:

============

Date: Wed, 25 May 2016 18:36:36 +0100 From: C R

It's definitely faster, and more convenient. I also like the fact that ctrl+shift+clicking a masked layer removes the mask. It makes a pain-free toggle, I can see myself using it a lot.

The only thing I would add is that if there is a selection on the canvas, that the mask be made from that selection. More often than not I'm making a mask out of the current selection, so it would save me several hotkey presses after using the new ctrl+shift+click layer mask feature.

Thanks for trying it out. You can also use ctrl-alt-click to bring up the dialog instead of the predefined value.

============

Date: Wed, 25 May 2016 22:30:11 +0300

From: Alexandre Prokoudine
Something I'm not sure about is that Ctrl+Shift+Click on the mask preview toggles visibility of the mask. I never used this shortcut on the mask before, so I'm not certain if it had existed before or if it has just been added as part of the patch. In other words: is it expected behavior?

There was no such shortcut till the patch. Using it either adds or removes a layer mask (if it exists on the layer).

Another thing is that another mask-related setting -- default quick

mask color -- is on a different tab. Should they be on the same tab instead?

I don't think so.

Other than that, I'd be happy to see the patch applied.

Thanks for trying it out. You can also use ctrl-alt-click to bring up the dialog instead of the predefined value.

Ben

_______________________________________________ gimp-developer-list mailing list
List address: gimp-developer-list@gnome.org List membership:
https://mail.gnome.org/mailman/listinfo/gimp-developer-list List archives: https://mail.gnome.org/archives/gimp-developer-list

On 10 June 2016 at 18:06, C R wrote:

[image: Boxbe] This message is eligible for Automatic Cleanup! (cajhne@gmail.com) Add cleanup rule

| More info

Can I bribe someone to commit/add this to trunk (even on a trial basis)? :)

-C

Ask mitch

Who is Mitch?

On Mon, Jun 13, 2016 at 8:57 AM, Joseph Bupe wrote:

On 10 June 2016 at 18:06, C R wrote:

[image: Boxbe] This message is eligible for Automatic Cleanup! (cajhne@gmail.com) Add cleanup rule

| More info

Can I bribe someone to commit/add this to trunk (even on a trial basis)? :)

-C

Ask mitch

On Mon, Jun 13, 2016 at 1:21 PM, C R wrote:

Who is Mitch?

That would be Michael Natterer, the author of merely 90% commits lately :)

Alex

Seriously?? :) He is only the lead GIMP developer.

On Mon, Jun 13, 2016 at 6:21 AM, C R wrote:

Who is Mitch?

On Mon, Jun 13, 2016 at 8:57 AM, Joseph Bupe wrote:

On 10 June 2016 at 18:06, C R wrote:

[image: Boxbe] This message is

eligible

for Automatic Cleanup! (cajhne@gmail.com) Add cleanup rule <

https://www.boxbe.com/popup?url=https%3A%2F%2Fwww.boxbe.com%2Fcleanup%3Fkey%3DRRw%252FTGfa77MVzy4Es24l79Kzz81bHpclnptE9Jw49Dg%253D%26token%3DRy6i1LHoty9RBJJPXE3404aKmYWkEDB8WB1x89Nv9fRSNkmP8cB%252F0VSsrOKfTW%252Bcb0N6wDZgi1Sd%252BgKq2dBdM23BsIRW%252BKVdtpB1fCyu%252ByGeVuJHVsyYCCrjISZ73VhMTqfkPyiRHqw%253D&tc_serial=25714979786&tc_rand=526132613&utm_source=stf&utm_medium=email&utm_campaign=ANNO_CLEANUP_ADD&utm_content=001

| More info
<

http://blog.boxbe.com/general/boxbe-automatic-cleanup?tc_serial=25714979786&tc_rand=526132613&utm_source=stf&utm_medium=email&utm_campaign=ANNO_CLEANUP_ADD&utm_content=001

Can I bribe someone to commit/add this to trunk (even on a trial basis)? :)

-C

Ask mitch

_______________________________________________ gimp-developer-list mailing list
List address: gimp-developer-list@gnome.org List membership:
https://mail.gnome.org/mailman/listinfo/gimp-developer-list List archives: https://mail.gnome.org/archives/gimp-developer-list

Seriously?? :) He is only the lead GIMP developer.

Maintainer, to be more specific.

Ah, Michael Natterer is aka "mitch". Sure I'll poke him.

On Mon, Jun 13, 2016 at 1:40 PM, Joseph Bupe wrote:

Seriously?? :) He is only the lead GIMP developer.

Maintainer, to be more specific.

I have poked. I hope he likes coffee. lol -C

On Mon, Jun 13, 2016 at 2:08 PM, C R wrote:

Ah, Michael Natterer is aka "mitch". Sure I'll poke him.

On Mon, Jun 13, 2016 at 1:40 PM, Joseph Bupe wrote:

Seriously?? :) He is only the lead GIMP developer.

Maintainer, to be more specific.

Some progress then! Cool.

Not yet, waiting for reply. :)
-C

On Mon, Jun 13, 2016 at 2:58 PM, Joseph Bupe wrote:

Some progress then! Cool.

No, he is the lead developer. You do realize that GIMP is being actively developed?

Maintainer means totally different thing.

On Mon, Jun 13, 2016 at 8:40 AM, Joseph Bupe wrote:

Seriously?? :) He is only the lead GIMP developer.

Maintainer, to be more specific.

Well, he is both.

Hi Ben / Draekko software.
Looks Like Mich asked you to come to IRC to discuss changes to the patch. https://bugzilla.gnome.org/show_bug.cgi?id=759601

Can you follow up with him?

Thanks, for your work and your continued help to make the patch a part of GIMP.
-C

On Mon, Jun 13, 2016 at 6:21 PM, Joseph Bupe wrote:

Well, he is both.

Hi Ben,

mitch invited you to discuss this at http://irc.lc/gimp/gimp

On Thu, 2016-07-14 at 08:01 -0400, Ben wrote:

Hi C,

I just posted to the bug report where i was at on this issue. I'm rather 
tired of debating it and bending over making changes. It either stands 
as is or dies. Have a good one.

As I explained in the patch, I'd like to discuss some things about the patch, especially an approach to bring such dialog defaults to preferences in a more general manner.

I'm sorry that it took me so long to have a closer look, this is all done in free time of which I can't generate more, but I also can't push patches I'm not happy with just because of lack of time.

Dunno how to proceed, the patch will clearly go in in some form, do you still want to discuss it?

Regards, Mitch

On 07/01/2016 09:56 AM, C R wrote:

Hi Ben / Draekko software.
Looks Like Mich asked you to come to IRC to discuss changes to the patch.
https://bugzilla.gnome.org/show_bug.cgi?id=759601

Can you follow up with him?

Thanks, for your work and your continued help to make the patch a part 
of GIMP.
-C

On Mon, Jun 13, 2016 at 6:21 PM, Joseph Bupe > wrote:

    Well, he is both.

_______________________________________________ gimp-developer-list mailing list
List address:    gimp-developer-list@gnome.org List membership: https://mail.gnome.org/mailman/listinfo/gimp-develop er-list
List archives:   https://mail.gnome.org/archives/gimp-developer-list

Hi Michael. The help that you need to revise the patch to your liking, is it strictly code? Or would you like some user feedback for the changes you want?

I would be happy to assist with the later if Ben is too busy to continue, if you want to make the code changes yourself.

Thanks. -C

On Thu, Jul 14, 2016 at 7:10 AM, Michael Natterer wrote:

On Thu, 2016-07-14 at 08:01 -0400, Ben wrote:

Hi C,

I just posted to the bug report where i was at on this issue. I'm rather
tired of debating it and bending over making changes. It either stands
as is or dies. Have a good one.

As I explained in the patch, I'd like to discuss some things about the patch, especially an approach to bring such dialog defaults to preferences in a more general manner.

I'm sorry that it took me so long to have a closer look, this is all done in free time of which I can't generate more, but I also can't push patches I'm not happy with just because of lack of time.

Dunno how to proceed, the patch will clearly go in in some form, do you still want to discuss it?

Regards, Mitch

On 07/01/2016 09:56 AM, C R wrote:

Hi Ben / Draekko software.
Looks Like Mich asked you to come to IRC to discuss changes to the patch.
https://bugzilla.gnome.org/show_bug.cgi?id=759601

Can you follow up with him?

Thanks, for your work and your continued help to make the patch a part
of GIMP.
-C

On Mon, Jun 13, 2016 at 6:21 PM, Joseph Bupe > wrote:

Well, he is both.

_______________________________________________ gimp-developer-list mailing list
List address: gimp-developer-list@gnome.org List membership: https://mail.gnome.org/mailman/listinfo/gimp-develop er-list
List archives: https://mail.gnome.org/archives/gimp-developer-list

_______________________________________________ gimp-developer-list mailing list
List address: gimp-developer-list@gnome.org List membership:
https://mail.gnome.org/mailman/listinfo/gimp-developer-list List archives: https://mail.gnome.org/archives/gimp-developer-list

In addition to the Ctrl+Shift+click, I suggest we add a button in place of the "Anchor the floating layer" button for bringing up the dialog. Key combinations are easily forgotten when they are too many.

I guess we will not need a button for auto-anchoring floating selection.

Regards.