Sign up now! · Forgot password?
RSS/Atom feed identi.ca Twitter

[PATCH] Code fixes for -ansi -pedantic build

This discussion is connected to the gimp-developer-list.gnome.org mailing list which is provided by the GIMP developers and not related to gimpusers.com.

This is a read-only list on gimpusers.com so this discussion thread is read-only, too.

1 of 1 message available
Toggle history

Please log in to manage your subscriptions.

[PATCH] Code fixes for -ansi -pedantic build Daniel Richard G. 20 May 07:59
Daniel Richard G.
2006-05-20 07:59:04 UTC (almost 12 years ago)

[PATCH] Code fixes for -ansi -pedantic build

I usually build with -ansi -pedantic in my CFLAGS, to prevent silly non-portable-isms from slipping into my code. As it happens, GIMP CVS has a few of these, but they are easily addressed and I have submitted a patch to that effect:

http://bugzilla.gnome.org/show_bug.cgi?id=342390

The most worrisome bits are in four (now three) particular plug-ins, where you have non-static, non-extern variables being defined in common header files---leading, of course, to the linker bombing out on multiply-defined symbols.

--Daniel