"Adam D. Moss" writes:

Hi.

I've been sitting on a backend patch for probably most of the year, that greatly improves the quality of positional/fixed dither -- against GIMP 2.0.x. I was hoping to find time to get a GIMP 2.1.x build working and forward-port the patch, but that didn't transpire and it's likely too late for 2.2 now...

I will attempt to file the 2.0.x patch in Bugzilla some time soon and if anyone cares they can forward-port it (hopefully the dithering back-end didn't suffer many changes during 2.1.x).

Since nobody except you understands this code, probably nobody touched it since 2.0 ;-) I would not object to sneak in an obvious improvement of dithering quality before 2.2 if you hurry submitting that patch...

ciao, --mitch

Hi,

"Adam D. Moss" writes:

I've been sitting on a backend patch for probably most of the year, that greatly improves the quality of positional/fixed dither -- against GIMP 2.0.x. I was hoping to find time to get a GIMP 2.1.x build working and forward-port the patch, but that didn't transpire and it's likely too late for 2.2 now...

I will attempt to file the 2.0.x patch in Bugzilla some time soon and if anyone cares they can forward-port it (hopefully the dithering back-end didn't suffer many changes during 2.1.x).

Please do file your bug report as soon as possible. We might even still sneak it into 2.2 if you are confident that your changes don't introduce any major bugs.

Sven

Adam D. Moss wrote:

Ah, it's worse than I remembered, since the patch is actually against GIMP 1.2! But I'm compiling up GIMP 2.0.x now and so hope to have time to port this to 2.0 today, and from there hopefully it's only a short hop to 2.1.x (but I can't test that).

Why can't you test 2.1 (or 2.2pre, rather)? On a decent distro, getting all of the dependencies of 2.0 should get you ready for building 2.1/2pre without any additional work.

Michael

Hi,

"Adam D. Moss" writes:

Submitted as bug 161113. I've given it the usual selection of tests and I'm confident that it doesn't introduce any major bugs...

It's in CVS now.

I'll see if I can move my tree to 2.2pre tonight, though I suspect that the patch in that bug should apply to 2.2 pretty cleanly, since it's all 'deep code' stuff and would probably only collide with any cosmetic code-formatting changes.

We refrainded from doing any cosmetic code-formatting changes to that part of the GIMP code.

Sven