RSS/Atom feed Twitter
Site is read-only, email is disabled

Colour management - who can do what?

This discussion is connected to the gimp-developer-list.gnome.org mailing list which is provided by the GIMP developers and not related to gimpusers.com.

This is a read-only list on gimpusers.com so this discussion thread is read-only, too.

11 of 11 messages available
Toggle history

Please log in to manage your subscriptions.

GIMP 2.2 Sven Neumann 06 Sep 17:52
  GIMP 2.2 Dave Neary 06 Sep 18:06
  GIMP 2.2 David Odin 06 Sep 18:13
  GIMP 2.2 Robert L Krawitz 06 Sep 18:15
  Colour management - who can do what? Alastair M. Robinson 07 Sep 00:21
   Colour management - who can do what? Robert L Krawitz 07 Sep 02:30
    Colour management - who can do what? Alastair M. Robinson 07 Sep 20:34
     Colour management - who can do what? Robert L Krawitz 08 Sep 01:17
   Colour management - who can do what? Sven Neumann 07 Sep 20:54
GIMP 2.2 William Skaggs 06 Sep 20:16
  GIMP 2.2 Sven Neumann 06 Sep 20:45
Sven Neumann
2004-09-06 17:52:20 UTC (over 19 years ago)

GIMP 2.2

Hi,

a while ago we decided for a feature freeze for GIMP 2.2 that should have taken effect last week. I haven't enforced this feature freeze yet because there's been some good hacking going on recently and I think we definitely wanted to have these features in 2.2. With the 2.1.4 release, we've reached a point where the new stuff (GimpProgress, GimpPreview) seems to be rather well working so we could declare a feature freeze right now. I do think however that we should give us a little bit more time and try to get the following done during the next weeks:

- add more plug-in previews - try to make the previews scale with the dialog - implement color management as was discussed earlier - fix unit handling and resize / scale dialogs - allow for better layer positioning / alignment - integrate the metadata editor that Raphael is working on - finish and fix whatever is unfinished or broken

I would suggest we attempt to get a 2.2 prerelease out by the end of this month or early in october. Given the fact that the tree is fairly stable, we should then be able to deliver 2.2.0 by the end of october.

Please comment on this proposal if you disagree with it or think there are important features missing that you are already working on.

Sven

Dave Neary
2004-09-06 18:06:51 UTC (over 19 years ago)

GIMP 2.2

Hi,

Quoting Sven Neumann :

I do think however that we
should give us a little bit more time and try to get the following done during the next weeks:

- add more plug-in previews - try to make the previews scale with the dialog - implement color management as was discussed earlier - fix unit handling and resize / scale dialogs - allow for better layer positioning / alignment - integrate the metadata editor that Raphael is working on - finish and fix whatever is unfinished or broken

I would suggest we attempt to get a 2.2 prerelease out by the end of this month or early in october. Given the fact that the tree is fairly stable, we should then be able to deliver 2.2.0 by the end of october.

Sounds good. I think that we will be in a good position to see in a couple of weeks time whether these features are going to be in 2.2 or not - if there haven't been any commits in a 2.1.5 release or whatever for color management, for example, it is probably best not to wait for it. A pre-release in a month or so sounds good.

Cheers,
Dave.

--
Dave Neary
Lyon, France

David Odin
2004-09-06 18:13:09 UTC (over 19 years ago)

GIMP 2.2

On Mon, Sep 06, 2004 at 05:52:20PM +0200, Sven Neumann wrote:

Hi,

a while ago we decided for a feature freeze for GIMP 2.2 that should have taken effect last week. I haven't enforced this feature freeze yet because there's been some good hacking going on recently and I think we definitely wanted to have these features in 2.2. With the 2.1.4 release, we've reached a point where the new stuff (GimpProgress, GimpPreview) seems to be rather well working so we could declare a feature freeze right now. I do think however that we should give us a little bit more time and try to get the following done during the next weeks:

- add more plug-in previews

I'm already on this. If someone wants to help, please contact me.

- try to make the previews scale with the dialog

Just to make it clear, this would just resize the preview widget, nothing to do with a zoom feature.

- implement color management as was discussed earlier - fix unit handling and resize / scale dialogs - allow for better layer positioning / alignment - integrate the metadata editor that Raphael is working on - finish and fix whatever is unfinished or broken

I would suggest we attempt to get a 2.2 prerelease out by the end of this month or early in october. Given the fact that the tree is fairly stable, we should then be able to deliver 2.2.0 by the end of october.

Sounds reasonable.

DindinX

Robert L Krawitz
2004-09-06 18:15:40 UTC (over 19 years ago)

GIMP 2.2

From: Sven Neumann
Date: 06 Sep 2004 17:52:20 +0200

a while ago we decided for a feature freeze for GIMP 2.2 that should have taken effect last week. I haven't enforced this feature freeze yet because there's been some good hacking going on recently and I think we definitely wanted to have these features in 2.2. With the 2.1.4 release, we've reached a point where the new stuff (GimpProgress, GimpPreview) seems to be rather well working so we could declare a feature freeze right now. I do think however that we should give us a little bit more time and try to get the following done during the next weeks:

- add more plug-in previews - try to make the previews scale with the dialog - implement color management as was discussed earlier - fix unit handling and resize / scale dialogs - allow for better layer positioning / alignment - integrate the metadata editor that Raphael is working on - finish and fix whatever is unfinished or broken

I would suggest we attempt to get a 2.2 prerelease out by the end of this month or early in october. Given the fact that the tree is fairly stable, we should then be able to deliver 2.2.0 by the end of october.

Please comment on this proposal if you disagree with it or think there are important features missing that you are already working on.

I'd like to get a decision on what to do with the print plugin.

We (Gimp-Print) are in 5.0 beta, and I'd like for the GIMP 2.2 to use a 5.0-based plugin rather than a 4.2-based one. The Gimp-Print source tree has a GIMP 2.x-based plugin. There has been discussion about transferring ownership to the GIMP, and if this is going to happen it should be done soon. If it's going to stay in the Gimp-Print tree, it needs a maintainer, since the people who have been doing it aren't really GIMP experts nor UI programmers in general.

Particularly if there is to be color management in the GIMP, we need to look at this carefully. Doing 8 bit->8 bit color transformations prior to printing will yield quality problems that could be solved with 8 bit->16 bit transformations, as Gimp-Print can handle 16 bit input.

William Skaggs
2004-09-06 20:16:13 UTC (over 19 years ago)

GIMP 2.2

Sven wrote:

Please comment on this proposal if you disagree with it or think there are important features missing that you are already working on.

I don't disagree with it, but I wish you had mentioned specifically what I consider the biggest issue of all: bug #143668 (performance problems with GtkUIManager), which on a slow machine can make GIMP pause for 20 sec or more each time it creates an image. (Almost all this time is spent building the menus.) It would be a nightmare to release 2.2 without major improvement in this respect. The bug has been reassigned to Gtk+ rather than GIMP, but users aren't going to care.

Having spent some time on it myself, I think this bug is not going to be easy to solve, so it is disturbing that nobody is paying attention to it: the bug report has not even been commented on in over two months. If necessary I will take another shot at it myself, but I would prefer not to, for two reasons: first, I have been spending my time writing Help docs, and I believe it is possible to get the English part in good shape by the time 2.2 is released, but it will be much harder if I lose 1-2 weeks working on this bug; second, I don't really understand how the UI Manager works at all or how GIMP uses it.

Best, -- Bill


______________ ______________ ______________ ______________ Sent via the KillerWebMail system at primate.ucdavis.edu

Sven Neumann
2004-09-06 20:45:00 UTC (over 19 years ago)

GIMP 2.2

Hi,

"William Skaggs" writes:

I don't disagree with it, but I wish you had mentioned specifically what I consider the biggest issue of all: bug #143668 (performance problems with GtkUIManager), which on a slow machine can make GIMP pause for 20 sec or more each time it creates an image. (Almost all this time is spent building the menus.) It would be a nightmare to release 2.2 without major improvement in this respect. The bug has been reassigned to Gtk+ rather than GIMP, but users aren't going to care.

Having spent some time on it myself, I think this bug is not going to be easy to solve, so it is disturbing that nobody is paying attention to it: the bug report has not even been commented on in over two months. If necessary I will take another shot at it myself, but I would prefer not to, for two reasons: first, I have been spending my time writing Help docs, and I believe it is possible to get the English part in good shape by the time 2.2 is released, but it will be much harder if I lose 1-2 weeks working on this bug; second, I don't really understand how the UI Manager works at all or how GIMP uses it.

Sure, someone needs to have a look at this. I don't believe that it isn't possible to solve this. It is certainly just some stupid code that iterates over the same lists over and over again. These kind of performance problems are usually easy to solve as soon as one has found the culprit.

The problem here is that this issue can most probably only be solved in GTK+. That makes us depend on the GTK+ developers to release a version that has this bug fixed. But since we have been working together quite nicely in the past, I think we will get such a version released as soon as we have helped to fix the problem.

Sven

Alastair M. Robinson
2004-09-07 00:21:49 UTC (over 19 years ago)

Colour management - who can do what?

Hi Sven,

Sven Neumann wrote:

- implement color management as was discussed earlier

Firstly, I've been quiet on this subject for a few weeks because I've bought a new printer, and my limited coding time has been spent tweaking gimp-print to settle one or two minor print quality issues!

But to refresh everyone's memory about colour management, here is a list of what I believe needs to be done:

1. Create a new class for colour-management preferences, as you suggested:

struct GimpColorConfig {
GObject parent_instance;

gboolean enabled;

gchar *monitor_profile; gchar *working_profile; gchar *proof_profile;
GimpColorIntent render_intent;
GimpColorIntent proofing_intent; };

We need to be able to get this information into both the display filters and plugins. (Read only is probably sufficient for now.)

2. Modify the display filter interface to allow the current image to be referenced from within.

3. Allow the creation of a global display filter that will apply to all open images (unless disabled through an image parasite) and to the colour-selectors too. (For the latter, the image parameter passed to the module will be NULL)

4. Create a plugin that can transform an image between arbitrary RGB profiles. This plugin will need to be capable of using as source a binary profile attached to the image as a parasite "icc-profile", as applied by the TIFF loader. It will also need a user interface for interactive use.

5. When an image is newly loaded it should be checked for an icc-profile parasite, and if one is found the user should be given the *option* of converting the image to the current working space. If the user agrees, the parasite should be flushed after conversion, because the image will now be in the working space. If the user declines, a further parasite should be attached to the image that will disable colour-matching in the global display filter.

6. Image saving: some savers already support ICC profiles, as a binary parasite. We could simply load in the working profile and attach it as a parasite before saving, or we could do something smarter, providing the savers with access to the structure outlined in (1).

Does anyone have anything to add to this list, or can anyone see any fatal flaws or other problems that need to be resolved?

And the ultimate question: who's going to do what?

I can put some time into this, but probably not enough to do the entire list. Since I don't currently know GIMP's internals very well I think my time would best be spent working on the plugin mentioned in (4) and the display filters themselves, but points 1 and especially 2 need to be done first.

All the best,
--
Alastair M. Robinson

Robert L Krawitz
2004-09-07 02:30:34 UTC (over 19 years ago)

Colour management - who can do what?

Date: Mon, 06 Sep 2004 23:21:49 +0100 From: "Alastair M. Robinson"

Sven Neumann wrote:

> - implement color management as was discussed earlier

Firstly, I've been quiet on this subject for a few weeks because I've bought a new printer, and my limited coding time has been spent tweaking gimp-print to settle one or two minor print quality issues!

Which we've very much appreciated, even though I still have to try out your latest. I've been busy with other things, like making dcraw do the right (IMHO) thing. But I digress.

But to refresh everyone's memory about colour management, here is a list of what I believe needs to be done: ...
Does anyone have anything to add to this list, or can anyone see any fatal flaws or other problems that need to be resolved?

It would *really* be helpful to plug this into the Print plugin, if not Gimp-Print itself, so that when the GIMP feeds 8 bit values to the plugin these values are reprocessed into 16 bit values, rather than 8 bit ones.

Alastair M. Robinson
2004-09-07 20:34:41 UTC (over 19 years ago)

Colour management - who can do what?

Hi Robert,

Robert L Krawitz wrote:

Firstly, I've been quiet on this subject for a few weeks because I've bought a new printer, and my limited coding time has been spent tweaking gimp-print to settle one or two minor print quality issues!

Which we've very much appreciated, even though I still have to try out your latest. I've been busy with other things, like making dcraw do the right (IMHO) thing. But I digress.

Don't worry, I wasn't feeling unappreciated - just torn between two projects, like yourself :)

It would *really* be helpful to plug this into the Print plugin, if not Gimp-Print itself, so that when the GIMP feeds 8 bit values to the plugin these values are reprocessed into 16 bit values, rather than 8 bit ones.

This should be a fairly trivial change once we have the infrastructure to get the current working profile and/or the image's profile into plugins in general.

The print plugin would itself need to link against lcms, and it would simply fetch the current working profile (or the image's own profile if there is one), and create a transform from 8-bit data in the source profile to 16-bit data in the destination profile.

The sticking point would be the destination profile - the user would need one that accurately describes gimp-print's characteristics! We could of course just use sRGB (which lcms has built-in) as a default.

All the best, --
Alastair M. Robinson

Sven Neumann
2004-09-07 20:54:18 UTC (over 19 years ago)

Colour management - who can do what?

Hi Alastair,

thanks for replying and collecting this list of TODO items. I will try to take care of implementing the features that we need in the core and in the module API. I just need to sit down with Mitch and discuss some remaining questions about the module API. I hope to have the needed infrastructure implemented by the end of next week. I will keep you informed and will ask for your advice when I run into problems.

Sven

Robert L Krawitz
2004-09-08 01:17:12 UTC (over 19 years ago)

Colour management - who can do what?

Date: Tue, 07 Sep 2004 19:34:41 +0100 From: "Alastair M. Robinson"

> It would *really* be helpful to plug this into the Print plugin, if > not Gimp-Print itself, so that when the GIMP feeds 8 bit values to the > plugin these values are reprocessed into 16 bit values, rather than 8 > bit ones.

This should be a fairly trivial change once we have the infrastructure to get the current working profile and/or the image's profile into plugins in general.

The print plugin would itself need to link against lcms, and it would simply fetch the current working profile (or the image's own profile if there is one), and create a transform from 8-bit data in the source profile to 16-bit data in the destination profile.

The sticking point would be the destination profile - the user would need one that accurately describes gimp-print's characteristics! We could of course just use sRGB (which lcms has built-in) as a default.

I'd really like to figure out the right thing for Gimp-Print to do here, and then apply the profile inside Gimp-Print.