Hi,

Carol Spears wrote:

since day one with the gimp, everytime i want to get the info dialog i first search the Image Menu. my reasoning is "Image -->Info". i am really not thinking of viewing anything, more like knowing ....

This is a reasonable suggestion.

Out of interest, are there other menu items that people would like to see elsewhere? This is not very difficult to do, but there has not (yet) been a proposition on where to put menu entries.

is it easy to change the info plugin to show also in the Image Menu?

No, not really... the menu entries are all defined in app/gui/image-menu.c and for consistency there are files containing the callbacks (the functions called when you select a menu item) for each submenu in -commands.[ch] (so, for example, the info window calback is in view-commands.c).

Here's a quick, untested patch against the 2.0 branch that changes the placement of that menu. This has probably changed in HEAD since mitch's work converting menus to be GtkAction based.

Cheers, Dave.

Hi,

Dave Neary wrote:

the menu entries are all defined in app/gui/image-menu.c

In 2.1, there is a file menu/image-menu.xml which defines the menu structure, which makes it even easier to change menu locations than before.

Here's a quick, untested patch against the 2.0 branch that changes the placement of that menu.

I should have at least *compiled* with the patch, I missed a line and this patch has a syntax error - updated patch applied.

Cheers, Dave.

Hi,

Carol Spears wrote:

is it impossible to have it show up in both menu locations?

No, not at all. You register the same callback twice for two different menu locations.

Cheers, Dave.

On Tue, 27 Apr 2004, Dave Neary wrote:

Date: Tue, 27 Apr 2004 11:42:33 +0200 From: Dave Neary
To: Carol Spears
Cc: GIMPDev
Subject: Re: [Gimp-developer] Image Info Dialog

Hi,

Carol Spears wrote:

since day one with the gimp, everytime i want to get the info dialog i first search the Image Menu. my reasoning is "Image -->Info". i am really not thinking of viewing anything, more like knowing ....

I always though of 'File, Properties' (or 'File, Get Info' because there is lots of kinds of file metadata, not specifcally related to the image drawable.

This is a reasonable suggestion.

Out of interest, are there other menu items that people would like to see elsewhere? This is not very difficult to do, but there has not (yet) been a

I very much want menus in other places. I filed this bug less than two weeks ago and it was rejected. http://bugzilla.gnome.org/show_bug.cgi?id=140439

I'm convinced that there will always be people who want menus in different places and that runtime customizable menus will eventually be needed. (It doesn't seem possible to have menus that will be comfortable for longterm Gimp, Adobe Photoshop, Corel Painter or Macromedia Fireworks users).

If the improvements to Script-Fu allow scripts to exactly place menu items (this seemed to be part of the plan) and assign shortcuts (but this wasn't mentioned) I will at least be able to use scripts to put some features exactly where I would like them to be. (It doesn't seem to be posible to use Script-Fu to add seperators either, I just get a menu item labelled ---).

proposition on where to put menu entries.

... so many things I'd like to mover around I wont even start to list them.

- Alan

Hi,

Carol Spears wrote:

another one that i stop and think about is the Layers -->Transparency -->Add Alpha Channel. while it is true that it only works on one layer at a time, it is also true that there is only one layer for it to work on. you could have it run from Image Menu or from the Layers Dialog or from the Layers Menu and have it add transparency to the only layer (the background layer) that doesnt have it.

I tend to agree with you on this. Are there any good arguments for having this in the Layer menu?

Cheers, Dave.

On Tue, 27 Apr 2004, Carol Spears wrote:

Carol Spears wrote:

since day one with the gimp, everytime i want to get the info dialog i first search the Image Menu. my reasoning is "Image -->Info". i am really not thinking of viewing anything, more like knowing ....

I always though of 'File, Properties' (or 'File, Get Info' because there is lots of kinds of file metadata, not specifcally related to the image drawable.

i can see the logic of "File -->Info" i just never thought that way myself.

i always want "Image Info", and the truth is, this dialog is so limited that it is still quicker to get the scale tool and pop up the scale dialog to get the width and height information which is usually what i am looking for.

crap, i am working so much on web pages with my wysmythingie (mozilla) that it is actually (truthfully) quicker to right click on the image and load that into the web browser for the height and width information.

I've gotten into the habit of hovering over the bottom right corner and rounding up to figure out the image size.

I'm thinking if we are both finding it a little bit awkward to quickly know the image dimensions then it is unlikely that we are the only ones and that it would be something worth improving.

Perhaps additional information in the status bar messages showing the selection dimensions and offsets would work? (Shown as a standard transient message, I am definately not advocating permanently grabbing a chunk of the statusbar.) I think, I hope something non-intrusive and relatively trivial could be done to make things a little bit easier, ideas? Should I file a request for enhancement?

- Alan

Or..press ctrl+shift + i - it is faster than hovering and guessing .

On Wednesday 28 April 2004 18:42, Alan Horkan wrote:

On Tue, 27 Apr 2004, Carol Spears wrote:

Perhaps additional information in the status bar messages showing the selection dimensions and offsets would work? (Shown as a standard transient message, I am definately not advocating permanently grabbing a chunk of the statusbar.) I think, I hope something non-intrusive and relatively trivial could be done to make things a little bit easier, ideas? Should I file a request for enhancement?

There is an enhancement request for showing the selection dimensions in Bugzilla
- search for it to add your comments/requests there.

As for the otehr image info, I suggest usiong the shortcut (defaults to ctrl+shift+i) to get it fast.

- Alan

Hi,

Dave Neary writes:

is it easy to change the info plugin to show also in the Image Menu?

No, not really... the menu entries are all defined in app/gui/image-menu.c and for consistency there are files containing the callbacks (the functions called when you select a menu item) for each submenu in -commands.[ch] (so, for example, the info window calback is in view-commands.c).

That's not accurate any longer. With current CVS the menu entry in question is defined in menus/image-menu.xml and it is trivially changed even by non-hackers.

There is also a plan for adding an "Image Attributes" or "Image Properties" dialog and extending the already existing "Layer Attributes" (and similar) dialogs. A prerequisite for this is to make all this stuff object properties. This is a nice task for a volunteer who wants to get into GIMP core hacking. Let me know if you are interested...

Sven

Hi,

Sven Neumann wrote:

There is also a plan for adding an "Image Attributes" or "Image Properties" dialog and extending the already existing "Layer Attributes" (and similar) dialogs. A prerequisite for this is to make all this stuff object properties. This is a nice task for a volunteer who wants to get into GIMP core hacking. Let me know if you are interested...

What stuff, exactly?

And for informational purposes, what's involved (in general) in converting a type object attribute to a generic GObject attribute? A link to a decent doc would probably do, if you had one handy.

Cheers, Dave.

Hi,

Dave Neary writes:

There is also a plan for adding an "Image Attributes" or "Image Properties" dialog and extending the already existing "Layer Attributes" (and similar) dialogs. A prerequisite for this is to make all this stuff object properties. This is a nice task for a volunteer who wants to get into GIMP core hacking. Let me know if you are interested...

What stuff, exactly?

Well, all the information that belongs to a drawable and/or image object should be object properties. This would be width, height, mode (RGB/Gray/Indexed), unit ... Having this information accessible (at least readable) via the GObject property system will make it a lot easier to write a more or less generic property dialog.

And for informational purposes, what's involved (in general) in converting a type object attribute to a generic GObject attribute? A link to a decent doc would probably do, if you had one handy.

A must-read for every core GIMP hacker:

http://le-hacker.org/papers/gobject/

The GIMP source code is a good example also. Check the app/config directory for a couple of classes that basically do no nothing but storing information as object properties.

Sven

* Sven Neumann [040430 12:17]:

Well, all the information that belongs to a drawable and/or image object should be object properties. This would be width, height, mode (RGB/Gray/Indexed), unit ... Having this information accessible (at least readable) via the GObject property system will make it a lot easier to write a more or less generic property dialog.

And for informational purposes, what's involved (in general) in converting a type object attribute to a generic GObject attribute? A link to a decent doc would probably do, if you had one handy.

A must-read for every core GIMP hacker:

http://le-hacker.org/papers/gobject/

The parameters to GEGL filters, ops etc. will also be gobject properties, this makes it much easier not only to automatically create UI's, but also to dynamically add functionality, since the api provided can be queried at run-time.

If GEGL Op's are to be the new default way of adding most plug-ins, most of the dialog code will probably disapperar,. or be a special case,. where a default ui that is a list of properties with the appropriate widgets for changing color, browsing for a file, selecting a drawable etc. can be defined.

/Øyvind K.