Sign up now! · Forgot password?
RSS/Atom feed identi.ca Twitter

Bug reports on PhotoShop "adjustment layers" vs "layer styles"

This discussion is connected to the gimp-developer-list.gnome.org mailing list which is provided by the GIMP developers and not related to gimpusers.com.

This is a read-only list on gimpusers.com so this discussion thread is read-only, too.

3 of 3 messages available
Toggle history

Please log in to manage your subscriptions.

Bug reports on PhotoShop "adjustment layers" vs "layer styles" Elle Stone 06 Feb 15:15
  Bug reports on PhotoShop "adjustment layers" vs "layer styles" Øyvind Kolås 06 Feb 15:30
   Bug reports on PhotoShop "adjustment layers" vs "layer styles" Elle Stone 06 Feb 16:19
Elle Stone
2018-02-06 15:15:23 UTC (19 days ago)

Bug reports on PhotoShop "adjustment layers" vs "layer styles"

This bug report:

https://bugzilla.gnome.org/show_bug.cgi?id=79025 original Summary: Add support for Photoshop Styles Summary modified to be: Add support for Photoshop Styles and adjustment layers

is marked as a duplicate of 13 other bug reports, including this bug report:

https://bugzilla.gnome.org/show_bug.cgi?id=98262 Summary: Adjustment Layers (like in Photoshop)

which has a comment that says PhotoShop layer styles and PhotoShop adjustment layers are "the same", which I take to mean that both could be implemented using substantially the same GEGL code.

Back when I used PhotoShop, I used the non-destructive "adjustment layers"
(https://www.photoshopessentials.com/photo-editing/adjustment-layers/) - Curves, Levels, Channel Mixer, and such - all the time, with every single photograph I ever edited.

I think I used "layer styles" (https://helpx.adobe.com/photoshop/using/layer-effects-styles.html) only once during the entire time I used PhotoShop, as part of making a fancy logo for a website.

The applicable GIMP bug reports are quite old, dating as far back as 2002.

From the vantage point of "GEGL code in 2018", are the functionalities of PhotoShop "adjustment layers" and "layer styles" similar enough from an implementation point of view that both could be implemented all at once, using the same GEGL code? Or would there need to be substantially different/additional code for layer styles, compared to adjustment layers?

Best, Elle

Øyvind Kolås
2018-02-06 15:30:51 UTC (19 days ago)

Bug reports on PhotoShop "adjustment layers" vs "layer styles"

On Tue, Feb 6, 2018 at 4:15 PM, Elle Stone wrote:

From the vantage point of "GEGL code in 2018", are the functionalities of PhotoShop "adjustment layers" and "layer styles" similar enough from an implementation point of view that both could be implemented all at once, using the same GEGL code? Or would there need to be substantially different/additional code for layer styles, compared to adjustment layers?

Yes - both are non-destructive editing features, and can be impleemnted by inserting additional GeglNodes in the chain/graph of nodes that represent the layer stack. Applying a drop-shadow to the raster output of a part is no different from applying a color adjustment. The live previews done for GEGL based filters in GIMP-2.9 are already done by inserting a temporary one-off adjustment layer on the relevant layer, "inside a layer group".

/pippin

Elle Stone
2018-02-06 16:19:25 UTC (19 days ago)

Bug reports on PhotoShop "adjustment layers" vs "layer styles"

On 02/06/2018 10:30 AM, Øyvind Kolås wrote:

On Tue, Feb 6, 2018 at 4:15 PM, Elle Stone wrote:

From the vantage point of "GEGL code in 2018", are the functionalities of PhotoShop "adjustment layers" and "layer styles" similar enough from an implementation point of view that both could be implemented all at once, using the same GEGL code? Or would there need to be substantially different/additional code for layer styles, compared to adjustment layers?

Yes - both are non-destructive editing features, and can be impleemnted by inserting additional GeglNodes in the chain/graph of nodes that represent the layer stack. Applying a drop-shadow to the raster output of a part is no different from applying a color adjustment. The live previews done for GEGL based filters in GIMP-2.9 are already done by inserting a temporary one-off adjustment layer on the relevant layer, "inside a layer group".

/pippin

Pippin - thanks!

Best,
Elle