On Sun, Aug 20, 2017 at 4:07 PM, Gimp-Monkey wrote:

sample guide points / anchor points

An example of how it might look. The functionality is multiple: 1) a visual marker
2) a snapable guide point
3) an anchor for transformations
4) embedded information that can be exported for use in animations or situation where you want to track position with offsets. 5) Pinned and locked points could restrict movement of a layer, even possible am area.

Hi,

First of all, it does look interesting, although:

a) I'm not sure I understand 3), b) and 5) is already implemented in v2.9.x (git master branch, as well as 2.9.2 through 2.9.6) in a more common way, through the Layers dialog.

It looks like it could also address the recent request for a Photoshop-like Count tool that adds similar points to count features in an image. See
https://helpx.adobe.com/photoshop/using/counting-objects-image.html for more details.

It also looks like you either hacked this into the Move tool (and renamed it) or based in on the Move tool. Which one is it?

Finally, as far as I can tell, your code is based on GIMP 2.8.x code base. We recently moved canvas interaction code from tools to new reusable (sub)classes in git master (and 2.9.6), so you'd have to update your patch accordingly to make it work with upcoming 2.10. You'd have to look at subclasses of GimpToolWidet or ask mitch directly on IRC for more hints. And I have a strong suspicion that updating your code to work with git master would be a hard requirement for code review, should mitch et al. decide to include this.

Alex

Hi,

On Sun, Aug 20, 2017 at 7:34 AM, Gimp-Monkey wrote:

I know someone must have been wanting or even working on this. I would like to make a plugin or extension that is basically guide point. Like the current Guides (h and v line) it would be a point. These are good for snapping image parts together: think sprites that have multiple parts. If this concept if taken to its conclusion they could also be like simple bines allowing / restricting rotation, offset amounts.

"Guide points" are definitely an interesting feature.

As a part of this all Guides could be assignable to the image or individual layers / groups. Currently of course guides are associated with an image.

I have already written gui driven plugin for this, however it does not actually display or restrict or snap. It simple serves as a method for storing important points associated with an image or its drawables.

Alexandre's comment seems to imply you have your code somewhere accessible online. But unless I am blind, I don't see any link anywhere…
And yes, please work off of master git: https://git.gnome.org/browse/gimp/ Do not work from a tarball from older releases or from code based out of other branches.

Now the question... is anyone already doing this? If so can I help?

I don't think anyone is doing this. Actually I don't think this was every proposed (though I don't know all our bug requests). So feel free to propose patches. We will review thoroughly, may ask you to change stuff, improve code quality (if needed), fix stuffs, but personally I would vouch for such a feature. And I think others will as well.

If not anyone have suggestions for how to implement a small and simple anchor icon that is not part of pixel data? Any suggestions how to have the cursor snap to these points?

There is a feature called "Sample points" which is actually not well known. To create a sample point, you can ctrl-click the rulers (this usage makes it kind of a "friend" of guides then, even though AFAIK it doesn't share code) on the side and drag onto the canvas. It will create numbered points on the canvas. Its main usage though is with the dock named "Sample Points" to get color information under the point.
It may be interesting to enhance this feature to make it usable for other things, like snapping. The "visual" part is already there, though you seem to propose various visuals (squares, circles, triangles…). I must say I'm not sure about this part of your proposal. At least not at first.

Of course some could argue that it may be better to create a separate feature, but I'm not sure it would be better.

Also in our code, sample points seem to be an independent structure. IMO it could be a good idea to make guide and sample points as both children of a common parent class for such features.

Also some paint programs offer guides (lines) that are any angle, not just h and v. I realize these are not often that useful but there are many times I have wished for these to help especially when doing transformations.

Free-angle guides would be definitely useful. As much as I haven't seen a feature request for guide points until now, we are regularly asked for free-angle guides, and we have a bug report, even with a tentative patch by a contributor:
https://bugzilla.gnome.org/show_bug.cgi?id=344109 I have myself several times considered to look into implementing this (but always had other priorities).
So you are more than welcome to look at current implementation and propose a patch for this.

As a general rules, our guides are currently quite basic and would deserve to improve. We also have a lot of requests around better guide management too. For instance:
https://bugzilla.gnome.org/show_bug.cgi?id=754515 In any case, propositions and patches welcome.

Jehan

Live long and may your gimp prosper.

-- Gimp-Monkey (via www.gimpusers.com/forums) _______________________________________________ gimp-user-list mailing list
List address: gimp-user-list@gnome.org List membership: https://mail.gnome.org/mailman/listinfo/gimp-user-list List archives: https://mail.gnome.org/archives/gimp-user-list

ZeMarmot open animation film
http://film.zemarmot.net
Patreon: https://patreon.com/zemarmot
Tipeee: https://www.tipeee.com/zemarmot

On 08/27/17 19:42, Jehan Pagès wrote:

As a general rules, our guides are currently quite basic and would deserve to improve. We also have a lot of requests around better guide management too. For instance:
https://bugzilla.gnome.org/show_bug.cgi?id=754515 In any case, propositions and patches welcome.

The already existing snapping to paths already answers some of these questions, even if it could be improved (I would much prefer to designate a specific path as being the snapping target).

Actually - from yoru description I guess you've created a Plugin UI where a copy of the image is shown and one draws the points?

That would be pretty close to unusable -

I suggest you do abuse from the "path" tool at this point, which allows one to place independent handles already (although unconnected points require modifier + click) - -Then yu get the points, snap capability, and you can have a plug-in, or group of simpler plug-ins that could be grouped on a submenu, to perform actions based on points of the currently selected path.

On 27 August 2017 at 14:52, Gimp-Monkey wrote:

Thank you for the feedback. In fact the images are all mockups aka doctored
screen shots and not the implementation. What I have actually got done are the
dialogs and representation code doe the points / anchors via parasites. I started researching how to pain them on the canvas independant of any drawable
but got a little stuck there. So... hopefully next week when I have a nice bock
of time I can unravel those mysteries. I will check out the ideas referenced and
yeah look at 2.10. Thanks again.

Hi,

First of all, it does look interesting, although:

a) I'm not sure I understand 3), b) and 5) is already implemented in v2.9.x (git master branch, as well as 2.9.2 through 2.9.6) in a more common way, through the Layers dialog.

It looks like it could also address the recent request for a Photoshop-like Count tool that adds similar points to count features in an image. See
https://helpx.adobe.com/photoshop/using/counting-objects-image.html for more details.

It also looks like you either hacked this into the Move tool (and renamed it) or based in on the Move tool. Which one is it?

Finally, as far as I can tell, your code is based on GIMP 2.8.x code base. We recently moved canvas interaction code from tools to new reusable (sub)classes in git master (and 2.9.6), so you'd have to update your patch accordingly to make it work with upcoming 2.10. You'd have to look at subclasses of GimpToolWidet or ask mitch directly on IRC for more hints. And I have a strong suspicion that updating your code to work with git master would be a hard requirement for code review, should mitch et al. decide to include this.

Alex

--
Gimp-Monkey (via www.gimpusers.com/forums) _______________________________________________ gimp-user-list mailing list
List address: gimp-user-list@gnome.org List membership: https://mail.gnome.org/mailman/listinfo/gimp-user-list List archives: https://mail.gnome.org/archives/gimp-user-list