Den 04.04.2017 20:03, Elle Stone skreiv:

Hi All,

Since March 28 I've pushed 7 commits (not including a commit that only uploaded a new screenshot) for various color management/high bit depth related items.

If anyone has time to check my xml files for consistency, indentation, proper use of , , and such, that would help ensure that I don't continue making errors that will need to be fixed later.

I translated menus/colors/desaturation.po to Norwegian (nn). "make validate-nn" returned "no errors". (Not committed yet, needs proofreading etc.)
Ah, sees it's verified by Julien.

If anyone wants to check content for readability, suggestions for improvements are very welcome.

The desaturation.po is a well done job. I know very little about color management and likes the way you have designed the side. First all I need to use the tools and then further explanations.

Wrt to images, probably I should "png crush" and also make indexed images from many of the png files that I've uploaded. Advice is very welcome on how to proceed wrt to uploaded images.

I learned that all images should be indexed and with solution set to 144 ppi. (I do not know what "png crush" does so no answer from me about this).

Here are the commits with links to the corresponding online-documentation:

Thank you for your list. It simplifies my work. Kolbjrn

1. commit 1b42002d4894e713dd7180b738320d695ff63549 https://docs.gimp.org/2.9/en/gimp-filter-desaturate.html Julien already checked the xml file.

2. commit 33968f105974f9fb23fc502e882adb314a8ef5f4 https://docs.gimp.org/2.9/en/glossary.html Terms added:
Channel encoding
Color
Display-referred
Display-referred white
Display-referred black
High Dynamic Range
Scene-referred

3. commit 4b85e09374dc57a3e93668c010fac5813d974550 https://docs.gimp.org/2.9/en/gimp-image-convert-grayscale.html

4. commit 8f8821749d050e88241955e5d65f01382f7d9f97 https://docs.gimp.org/2.9/en/gimp-image-color-management.html https://docs.gimp.org/2.9/en/gimp-image-enable-color-management.html

5. commit 408556670ea74a530f3bdaf73b8d4e2903a7cfdb https://docs.gimp.org/2.9/en/gimp-image-precision.html

6. commit 93e6562a57dde4c74a386fe0717f4e4f7d719b9c https://docs.gimp.org/2.9/en/gimp-image-assign-color-profile.html

7. commit 5dc56155eeb08b11213d8d3507729e79f67bd226 https://docs.gimp.org/2.9/en/gimp-image-convert-to-color-profile.html (this page hasn't been built as of sending this email)

Best,

and thanks in advance for catching mistakes I might be making.

Elle _______________________________________________ gimp-docs-list mailing list
gimp-docs-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gimp-docs-list

On Thu, Apr 06, 2017 at 02:22:06PM -0400, Elle Stone wrote:

On 04/05/2017 08:54 AM, Elle Stone wrote:

Actually I'd suggest holding off on translating any of the color management menu pages as there are two more pages to write for the color management menu. These pages all go together, so likely I'll make minor changes to the "already done" pages while writing the "not yet done" pages.

I made some changes to the XML, and many thanks to Julien for the feedback - I think I have the indentation figured out now.

I simplified the Enable Color Management page and finished the last two items for the color management menu. So the Image/Color Management menu pages are ready for translating if anyone is so inclined.

Is this right?

src/menus/colors/desaturate/desaturate.xml:108(phrase)

The shades of gray will be calculated as



Lightness (HSL)) = ½ × (max(R,G,B) + min(R,G,B))

Marco Ciampa

I know a joke about UDP, but you might not get it.

------------------------

 GNU/Linux User #78271
 FSFE fellow #364

------------------------

On Fri, Apr 28, 2017 at 10:44:25AM -0400, Elle Stone wrote:

On 04/28/2017 04:35 AM, Marco Ciampa via gimp-docs-list wrote:

Is this right?

src/menus/colors/desaturate/desaturate.xml:108(phrase)

The shades of gray will be calculated as



Lightness (HSL)) = ½ × (max(R,G,B) + min(R,G,B))

If you mean the formula for Lightness, it's correct:

From 2.8 docs: Lightness

The graylevel will be calculated as Lightness = ½ × (max(R,G,B) + min(R,G,B))

From posted 2.9 docs: Lightness (HSL)

The shades of gray will be calculated as Lightness (HSL)) = ½ × (max(R,G,B) + min(R,G,B))

From Wikipedia (https://en.wikipedia.org): In the HSL "bi-hexcone" model, lightness is defined as the average of the largest and smallest color components (fig. 12c).

From GIMP code (app/operations/gimpoperationdesaturate.c): case GIMP_DESATURATE_LIGHTNESS:
/* This is the formula for Lightness in the HSL "bi-hexcone" * model: https://en.wikipedia.org/wiki/HSL_and_HSV */
while (samples--)
{
gfloat min, max, value;

max = MAX (src[0], src[1]); max = MAX (max, src[2]);
min = MIN (src[0], src[1]); min = MIN (min, src[2]);

value = (max + min) / 2;

Not to be confused with LAB/LCH Lightness, which is calculated from XYZ, not from RGB (http://brucelindbloom.com/index.html?Eqn_XYZ_to_Lab.html).

Many thanks Elle! Sorry for the noise!

Just a very minor typo: I think there is a spurious parenthesis after HSL ...

bye

--

Marco Ciampa

I know a joke about UDP, but you might not get it.

------------------------

GNU/Linux User #78271 FSFE fellow #364

------------------------